port position test to scalar #9128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weijun-H
approved these changes
Feb 5, 2024
|
sure |
comphead
previously requested changes
Feb 6, 2024
There was a problem hiding this comment.
nice, thanks @Lordworms
Since touching that, may I ask you to add tests with nulls and bad scenarios
select position(null in null)
select position('' in '')
select position(1 in 1)
and different other combinations in this direction
|
sure |
alamb
approved these changes
Feb 8, 2024
|
@comphead let us know what you think of this PR and if it is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
modify for #8922
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?